scsi: qla2xxx: Fix an integer overflow in sysfs code
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 30 Aug 2017 13:30:35 +0000 (16:30 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 19 Sep 2017 00:59:17 +0000 (01:59 +0100)
commit088a454caa7865492058cdafe17d448fcab89f09
tree9a060799de4debbb7970fba2b6f1e42ed1b845b6
parent5bea2edb792978efea3aa197c3ab0308d84bfecb
scsi: qla2xxx: Fix an integer overflow in sysfs code

The value of "size" comes from the user.  When we add "start + size" it
could lead to an integer overflow bug.

It means we vmalloc() a lot more memory than we had intended.  I believe
that on 64 bit systems vmalloc() can succeed even if we ask it to
allocate huge 4GB buffers.  So we would get memory corruption and likely
a crash when we call ha->isp_ops->write_optrom() and ->read_optrom().

Only root can trigger this bug.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=194061
Cc: <stable@vger.kernel.org>
Fixes: b7cc176c9eb3 ("[SCSI] qla2xxx: Allow region-based flash-part accesses.")
Reported-by: shqking <shqking@gmail.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name scsi-qla2xxx-Fix-an-integer-overflow-in-sysfs-code.patch
drivers/scsi/qla2xxx/qla_attr.c